[webview] Add new method for cross plugin webview access#11714
[webview] Add new method for cross plugin webview access#11714fuzzybinary wants to merge 4 commits into
Conversation
github-actions
Bot
added
platform-android
platform-ios
platform-macos
p: webview_flutter
labels
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new methods to access native WebView (Android) and WKWebView (iOS/macOS) instances using FlutterPluginBinding and FlutterPluginRegistrar, respectively, while deprecating the previous engine and registry-based approaches. The changes include updated unit tests and a minimum Flutter version bump to 3.44.0 for both packages. Review feedback identifies a pluralization inconsistency in the wkwebview changelog and an unnecessary downgrade of the Dart SDK constraint in its pubspec.yaml.
A new way of supporting cross plugin communication is coming in Flutter 3.44 which allows for access to plugin published values through the `FlutterPluginBinding` on Android and the `FlutterPluginRegistry` on iOS. Update native WebView access to support these new methods and deprecate the old methods. refs: flutter/flutter#121527 flutter/flutter#182753 # Conflicts: # packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml
fuzzybinary
force-pushed
the
webview-new-publish-api
branch
from
796dc17 to
c4d49c6
Compare
| environment: | ||
| sdk: ^3.10.0 | ||
| flutter: ">=3.38.0" | ||
| flutter: ">=3.44.0" |
There was a problem hiding this comment.
@stuartmorgan-g Does this PR need to wait until we bump all the plugins in the repo to 3.44? This isn't fixing a bug, so I don't think it is an exemption to support n-2 stable version.
There was a problem hiding this comment.
We don't require supporting N-2, we just don't allow supporting things older than N-2. We only require supporting stable.
This will need wait until Flutter master rolls to a version that reports being newer than a 3.44 pre-release though so that the resolver works (the usual problem we have with master right after a release).
| final WebViewFlutterPlugin webViewPlugin = | ||
| (WebViewFlutterPlugin) binding.getPlugin(WebViewFlutterPlugin.class); | ||
|
|
||
| if (webViewPlugin != null && webViewPlugin.getInstanceManager() != null) { |
There was a problem hiding this comment.
Everything from here on can be extracted to a private helper instead of duplicated.
| version: 4.13.0 | ||
|
|
||
| environment: | ||
| sdk: ^3.9.0 |
There was a problem hiding this comment.
We require that the Dart and Flutter versions align in our packages, so this needs to be updated as well.
|
We've rolled 3.44 |
# Conflicts: # packages/webview_flutter/webview_flutter_android/CHANGELOG.md # packages/webview_flutter/webview_flutter_android/pubspec.yaml
|
😬 When updating this it looks like there's a secondary problem. While Thoughts on the correct solution here? I can go in and add the I could mark the external method as iOS only for time being, then add the required method to macOS later... Suggestions @stuartmorgan-g ? Also question about the |
That's the simplest path forward; the pressing use case I'm aware of for this API is on iOS, so fixing it there faster is worth the temporary mismatch. The ifdef should have a TODO comment explaining why it's ifdef'd out, and linking to an issue filed to track adding the API to the macOS engine.
|
|
Looks like the min Dart SDK bump picked up some minor analyzer issues that will need to be fixed (due to a new Dart feature being available). |
3 participants
A new way of supporting cross plugin communication is coming in Flutter 3.44 which allows for access to plugin published values through the
FlutterPluginBindingon Android and theFlutterPluginRegistryon iOS. Update native WebView access to support these new methods and deprecate the old methods.refs: flutter/flutter#121527 flutter/flutter#182753
Pre-Review Checklist
[shared_preferences]///).